Skip to content

Fixing problem where tardy handlers inside hierarchy where not invoked #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixing problem where tardy handlers inside hierarchy where not invoked #313

wants to merge 1 commit into from

Conversation

@tanneberger
Copy link
Member

@tanneberger tanneberger commented Oct 31, 2025 •
edited
Loading

fixes #310

@tanneberger tanneberger self-assigned this Oct 31, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 31, 2025

Memory usage after merging this PR will be:

Memory Report

action_empty_test_c

from to increase (%)
text 69479 69795 0.45
data 752 752 0.00
bss 12416 12416 0.00
total 82647 82963 0.38

action_microstep_test_c

from to increase (%)
text 70308 70624 0.45
data 760 760 0.00
bss 12480 12480 0.00
total 83548 83864 0.38

action_overwrite_test_c

from to increase (%)
text 70185 70501 0.45
data 752 752 0.00
bss 12480 12480 0.00
total 83417 83733 0.38

action_test_c

from to increase (%)
text 70081 70397 0.45
data 760 760 0.00
bss 12480 12480 0.00
total 83321 83637 0.38

deadline_test_c

from to increase (%)
text 64936 65252 0.49
data 768 768 0.00
bss 11776 11776 0.00
total 77480 77796 0.41

delayed_conn_test_c

from to increase (%)
text 70423 70806 0.54
data 752 752 0.00
bss 13248 13248 0.00
total 84423 84806 0.45

event_payload_pool_test_c

from to increase (%)
text 24353 24353 0.00
data 720 720 0.00
bss 480 480 0.00
total 25553 25553 0.00

event_queue_test_c

from to increase (%)
text 29092 29092 0.00
data 728 728 0.00
bss 480 480 0.00
total 30300 30300 0.00

nanopb_test_c

from to increase (%)
text 44218 44218 0.00
data 1928 1928 0.00
bss 320 320 0.00
total 46466 46466 0.00

physical_clock_test_c

from to increase (%)
text 49792 49932 0.28
data 832 832 0.00
bss 640 640 0.00
total 51264 51404 0.27

port_test_c

from to increase (%)
text 70326 70709 0.54
data 752 752 0.00
bss 13056 13056 0.00
total 84134 84517 0.46

reaction_queue_test_c

from to increase (%)
text 28292 28292 0.00
data 728 728 0.00
bss 480 480 0.00
total 29500 29500 0.00

request_shutdown_test_c

from to increase (%)
text 70318 70634 0.45
data 752 752 0.00
bss 12480 12480 0.00
total 83550 83866 0.38

startup_test_c

from to increase (%)
text 64565 64881 0.49
data 760 760 0.00
bss 11776 11776 0.00
total 77101 77417 0.41

tcp_channel_test_c

from to increase (%)
text 92307 92447 0.15
data 2288 2288 0.00
bss 14720 14720 0.00
total 109315 109455 0.13

timer_test_c

from to increase (%)
text 64537 64853 0.49
data 752 752 0.00
bss 11776 11776 0.00
total 77065 77381 0.41

@github-actions
Copy link
Contributor

github-actions bot commented Oct 31, 2025 •
edited
Loading

Benchmark results after merging this PR:

Benchmark results

Performance:

PingPongUc:
Best Time: 235.926 msec
Worst Time: 237.415 msec
Median Time: 236.538 msec

PingPongC:
Best Time: 139.188 msec
Worst Time: 145.268 msec
Median Time: 139.533 msec

ReactionLatencyUc:
Best latency: 13240 nsec
Median latency: 60457 nsec
Worst latency: 3676501 nsec

ReactionLatencyC:
Best latency: 21316 nsec
Median latency: 60476 nsec
Worst latency: 4280474 nsec

Memory usage:

PingPongUc:
text data bss dec hex filename
37538 760 8472 46770 b6b2 bin/PingPongUc

PingPongC:
text data bss dec hex filename
47658 878 384 48920 bf18 bin/PingPongC

ReactionLatencyUc:
text data bss dec hex filename
23651 736 2520 26907 691b bin/ReactionLatencyUc

ReactionLatencyC:
text data bss dec hex filename
43200 846 384 44430 ad8e bin/ReactionLatencyC

@tanneberger tanneberger force-pushed the fixing-tardy-handlers branch from 7d3d291 to 77d6205 Compare October 31, 2025 19:31
@github-actions
Copy link
Contributor

github-actions bot commented Oct 31, 2025

Coverage after merging fixing-tardy-handlers into main will be

52.83%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   action.c70%65.38%62.50%71.88%113–114, 127–128, 131–134, 137–138, 140–143, 145, 149, 152–155, 25, 40–42, 46, 48, 55–56, 63–65, 65, 65–68
   builtin_triggers.c90.91%70%100%96.77%14, 18, 40, 43
   clock_synchronization.c0%0%0%0%100–103, 105–106, 106, 106–109, 114–116, 116, 116–118, 120–122, 122, 122–124, 124, 124, 124, 124–126, 129, 13, 130, 132, 135, 137–139, 14, 141, 143, 143, 143–145, 147–149, 149, 149–151, 154, 156, 158, 16, 160–161, 161, 161–163, 163, 163, 166, 166, 166–167, 17, 170–175, 175, 175–176, 18, 180, 182–188, 188, 188–189, 19, 192, 195–199, 20, 200, 200, 200–201, 203, 205, 208, 210–214, 214, 214–215, 215, 215–224, 224, 224–225, 227, 23, 23, 23, 230–232, 234–236, 238, 238, 238–239, 24, 241, 244–245, 247–249, 25, 250–254, 254, 254–256, 26, 26, 26, 261–264, 264, 264–266, 268–269, 27, 273–275, 277–278, 278, 278–279, 279, 279–287, 287, 287–288, 290, 294, 297–298, 30, 301–310, 310, 310–311, 314, 317–320, 323, 323, 323, 323, 323, 323, 323, 323, 323–329, 33, 330–339, 34, 340–344, 347–348, 35, 350, 354–362, 364, 367, 367, 367–368, 372–376, 379, 379, 379–380, 383, 385, 40, 42, 44, 46, 49, 49, 49–51, 51, 51–52, 55, 58, 62, 64–66, 66, 66, 69, 69, 69–70, 73–79, 79, 79–80, 83, 89–90, 93, 95, 95, 95–97
   connection.c78.71%53.33%100%88.12%10, 105, 111, 124–125, 139, 14, 14, 140, 146, 148–149, 151, 16–17, 21–22, 22, 22–23, 25, 27–28, 34, 48, 48, 48–49, 55, 61–63, 98
   environment.c94.12%83.33%100%100%16, 29
   event.c100%100%100%100%
   federated.c6.53%3.26%10%7.94%10, 100–103, 105, 105, 105–106, 108, 108, 108, 108, 108–109, 109, 109–111, 114, 114, 114–116, 120–121, 124–126, 126, 126–127, 127, 127–129, 13, 131, 134, 136, 138–143, 146–148, 15, 150, 150, 150, 152–155, 157, 159, 159, 159, 16, 160, 162–163, 166–167, 17, 174–176, 176, 176–177, 179, 18, 181, 181, 181–184, 184, 184, 184, 184, 184, 184–193, 193, 193–194, 196–199, 20, 20, 20, 200–203, 205–208, 21, 21, 21, 212, 215, 215, 215–217, 219, 221, 223–225, 225, 225, 225, 225–229, 23, 23, 23, 230–232, 234–237, 237, 237–238, 24, 240, 243–246, 248, 25, 25, 25, 254–256, 26, 269, 27, 270, 270, 270–271, 271, 271–272, 272, 272–273, 273, 273–274, 274, 274–275, 275, 275–276, 276, 276, 278, 278, 278–279, 279, 279–280, 280, 280–281, 281, 281–282, 282, 282, 284, 31–32, 36–41, 43, 45, 45, 45–46, 46, 46–47, 47, 47–48, 48, 48, 50, 52–55, 57, 57, 57–60, 60, 60–61, 63, 65–66, 66, 66–67, 71, 74–75, 75, 75–76, 78–80, 82, 86, 88, 90–92, 95, 97–99
   logging.c88.52%83.33%100%89.36%25, 38–40, 47, 60–61
   network_channel.c69.23%62.50%100%70.59%40, 40, 40, 45–48, 57
   physical_clock.c89.61%83.33%71.43%93.10%26, 41, 57–58, 81, 83
   port.c75%42.86%100%91.67%10, 10, 10, 15, 15, 15–16, 22, 26, 31, 31–33, 33, 33–34, 46, 46, 46–47
   queues.c86.11%79.03%100%88.03%100–106, 131–135, 138–139, 156, 161, 167, 34, 34, 38–44, 69–70, 96, 96
   reaction.c71.31%56.52%100%78.87%15, 21, 28–30, 30, 30–32, 32, 32–33, 43, 46, 53–54, 54, 54–56, 56, 56–57, 72, 88–90, 90, 90–93, 93, 93–94
   reactor.c69.33%51.52%100%82.28%10, 101–102, 14–19, 22, 28, 30, 32–37, 37, 37–38, 38, 38, 43, 55, 58–59, 59, 59–60, 60, 60–61, 63, 77–78, 81–82, 82, 82–83, 83, 83–84, 86, 91
   serialization.c37.50%25%50%40%16–17, 26–27, 33–34, 34, 34–35, 37–38, 41–42, 42, 42–43, 45–46
   startup_coordinator.c0%0%0%0%100,

@tanneberger tanneberger requested a review from fra-p November 1, 2025 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@edwardalee edwardalee Awaiting requested review from edwardalee

@erlingrj erlingrj Awaiting requested review from erlingrj

@fra-p fra-p Awaiting requested review from fra-p

Assignees

@tanneberger tanneberger

Labels

bugfix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

STP violations not handled across hierarchy

2 participants

@tanneberger